Skip to content

feat(inputs.smartctl): device name to attribute metrics#18679

Draft
hackery wants to merge 2 commits intoinfluxdata:masterfrom
hackery:feat/inputs-smartctl-attribute-tag
Draft

feat(inputs.smartctl): device name to attribute metrics#18679
hackery wants to merge 2 commits intoinfluxdata:masterfrom
hackery:feat/inputs-smartctl-attribute-tag

Conversation

@hackery
Copy link
Copy Markdown
Contributor

@hackery hackery commented Apr 9, 2026

Summary

Optional metric_version flag changes tag usage in the smartctl_attributes metrics to make name the device name (consistent with its use in the smartctl metrics) and putting the attribute name in a new attribute tag.

I don't know if this is the correct way to achieve this. metric_version is used elsewhere for similar purposes, but here seems a bit of a sledgehammer for a single tag name change. Would welcome alternative suggestions and quite prepared for PR to be rejected.

Checklist

Related issues

resolves #18385

feat(inputs.smartctl): device name to attribute metrics
5a7bdf1 
Optional `metric_version` flag changes tag usage in the
`smartctl_attributes` metrics to make `name` the device name (consistent
with its use in the `smartctl` metrics) and putting the attribute name
in a new `attribute` tag.
@telegraf-tiger telegraf-tiger Bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 9, 2026
Hipska
Hipska approved these changes Apr 9, 2026
View reviewed changes
Comment thread plugins/inputs/smartctl/sample.conf Outdated
## making it harder to associate them to the "smartctl" metrics.
## metric_version = 2 will use the "name" tag for the the device name,
## and a new "attribute" tag for the attribute name.
metric_version = 1
Copy link
Copy Markdown
Contributor

@Hipska Hipska Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default values can be commented out

Suggested change
metric_version = 1
# metric_version = 1

@hackery
Copy link
Copy Markdown
Contributor Author

hackery commented Apr 9, 2026

@srebhan via Slack suggested using a more specific option like enforce_device_name_tag, and also asked for a unit test to be added. I hope to get to that today and will update PR.

@Hipska
Copy link
Copy Markdown
Contributor

Hipska commented Apr 9, 2026

If your PR is not ready to be reviewed, please mark it as Draft.

@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger Bot commented Apr 9, 2026

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@hackery hackery marked this pull request as draft April 15, 2026 09:20
@srebhan srebhan self-assigned this Apr 27, 2026
@srebhan
Copy link
Copy Markdown
Member

srebhan commented Apr 28, 2026

@hackery any chance you work on this PR?

@srebhan srebhan added the waiting for response waiting for response from contributor label Apr 28, 2026
@hackery
Copy link
Copy Markdown
Contributor Author

hackery commented Apr 28, 2026

@srebhan yes, I'm going to rework it based on your suggestion. If I don't get to it this week, it'll be delayed as I'm away for two weeks after that.

@telegraf-tiger telegraf-tiger Bot removed the waiting for response waiting for response from contributor label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Hipska Hipska Hipska approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srebhan srebhan

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[[inputs.smartctl]] conflates name label for device name and attribute name

3 participants

@hackery @Hipska @srebhan